Fix issue with shorter vides (less than 3 seconds) causing issues with thumbnail generation #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently encountered some challenges while working with this gem, particularly in understanding the
:timeparameter, which was not clearly documented.Moreover, I faced issues when uploading videos shorter than 3 seconds. After a thorough review and analysis of the source code, I have implemented a fix.
As a solution, I've set the default value to check the video's length and, if it falls outside the
:timevalue, automatically selecting an appropriate frame, preferably the first one.I've also included a small description of the
:timeparameter to enhance the documentation.